Review Request: big revamp of Device Notifier

[Giulio Camuffo]

> On 2009-08-20 18:39:43, Kevin Ottens wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, line 369
> > <http://reviewboard.kde.org/r/1370/diff/1/?file=10366#file10366line369>
> >
> >     And what will happen for computers faster/slower than your? You should probably wait for a notification instead of using a timer with a magic value.

That line is a workaround. As explained on https://bugs.kde.org/show_bug.cgi?id=199860 the dataengine doesn't have the free space key immediately after the mount, and when it gets it, it doesn't emit a notification.


> On 2009-08-20 18:39:43, Kevin Ottens wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, line 338
> > <http://reviewboard.kde.org/r/1370/diff/1/?file=10366#file10366line338>
> >
> >     Urgh! Please no!
> >     
> >     You're hard depending on HAL now. It's doomed to fail if HAL behavior changes a bit, or if distros move away from it in favor of something else.
> >     
> >     We have the solid layer exactly to cope up with those changes. Please use it.

In fact I looked in the Solid documentation for a class to easily mount the devices, but I didn't find anything. 


- Giulio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2100
-----------------------------------------------------------


On 2009-08-20 17:26:01, Giulio Camuffo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> -----------------------------------------------------------
> 
> (Updated 2009-08-20 17:26:01)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is a patch that modifies quite heavily the behaviour of the Device Notifier.
> It comes from here: http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or with a click, since the "eject" button is a "mount" button when the volume is umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show all).
> Finally, it shows the various opening actions under the device instead of calling that xp-ish window.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 1010116 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 1010116 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 1010116 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 1010116 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 1010116 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 1010116 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 1010116 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> -------
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the options on my pc and they work. Some people on kde-look posted some comments about some problems, but it seems to me they are very particular cases, so in my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> -----------
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>