Review Request: kate session applet: allow keyboard only usage

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1358/#review2092
-----------------------------------------------------------

Ship it!


feel like doing the same thing for the konsole sessions plugin? :)

- Aaron


On 2009-08-19 13:28:48, Conrad Hoffmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1358/
> -----------------------------------------------------------
> 
> (Updated 2009-08-19 13:28:48)
> 
> 
> Review request for Kate and Plasma.
> 
> 
> Summary
> -------
> 
> The Kate session applet can be configured to pop up via a keyboard shortcut and the listed session can be navigated via the up and down arrow keys. Yet, a session can not be started by means of using the keyboard, a mouse click is currently required.
> 
> The attached patch fixes the problem by using the QTreeView::activated signal instead of the clicked signal. This also elegantly handles the single/double click issue.
> 
> 
> This addresses bug 203546.
>     https://bugs.kde.org/show_bug.cgi?id=203546
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdesdk/kate/plasma/session/katesessionapplet.cpp 1009608 
> 
> Diff: http://reviewboard.kde.org/r/1358/diff
> 
> 
> Testing
> -------
> 
> I compiled and installed it on my system and it behaves as expected. Notably, it still obeys the system wide single/double click setting.
> 
> 
> Thanks,
> 
> Conrad
> 
>