Review Request: Add HOME and END key navigation to folderview applet

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1329/#review2085
-----------------------------------------------------------

Ship it!


yes, to me looks fine, go for it

- Marco


On 2009-08-19 12:52:00, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1329/
> -----------------------------------------------------------
> 
> (Updated 2009-08-19 12:52:00)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This adds navigation support using the HOME and END keys. HOME moves to the first item, END moves to the last item.
> This applies only when the list is sorted, as in an unsorted view "start" and "end" do not make sense IMO. Let me know if this is right.
> 
> 
> This addresses bug 187241.
>     https://bugs.kde.org/show_bug.cgi?id=187241
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1013214 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1013214 
> 
> Diff: http://reviewboard.kde.org/r/1329/diff
> 
> 
> Testing
> -------
> 
> Tested when folderview is sorted using sort by Name, Type, Date etc. Works as expected.
> 
> 
> Thanks,
> 
> Shantanu
> 
>