[PATCH] BUG 203716 give user a hint when adding same application into quicklaunch

["潘卫平(Peter Pan)"]

潘卫平(Peter Pan) 写道:
> Aaron J. Seigo 写道:
>> On Friday 14 August 2009, 潘卫平(Peter Pan) wrote:
>>> svn r 1011382
>> there are a couple issues with this patch, unfortunately. first, it introduces 
>> a modal dialog. that will block the rest of plasma. not good. :/
>>
> That's really not good.
>> second, the button names are just "Ok" and "Cancel", they should be changed to 
>> having meaningful labels that say _what_ will happen if "Ok" or "Cancel" is 
>> pressed. but that's a moot point, because we really can't have a modal dialog 
>> here.
>>
>> is there any use case where it makes sense to have more than one icon for the 
>> _same_ application or file? i can't think of one. so i'd suggest just silently 
>> dropping duplicates.
>>
> I prefer to show user a warning message rather than drop it silently.
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Plasma-devel mailing list
>> Plasma-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
> 
> 

Every time you want to add an application, call checkDuplicateUrls() 
first.In this function, I give user a hint when we find duplicate URLs, 
then ignore them.

And setModal(false) for KMessageBox.

Regards
-- 
潘卫平(Peter Pan)
Red Flag Software Co., Ltd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdebase-quicklaunch-same.patch
Type: text/x-patch
Size: 3908 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090819/7baccdd2/attachment.patch