[PATCH] BUG 203716 give user a hint when adding same application into quicklaunch

Aaron J. Seigo aseigo at kde.org
Tue Aug 18 00:35:08 CEST 2009


On Friday 14 August 2009, 潘卫平(Peter Pan) wrote:
> svn r 1011382

there are a couple issues with this patch, unfortunately. first, it introduces 
a modal dialog. that will block the rest of plasma. not good. :/

second, the button names are just "Ok" and "Cancel", they should be changed to 
having meaningful labels that say _what_ will happen if "Ok" or "Cancel" is 
pressed. but that's a moot point, because we really can't have a modal dialog 
here.

is there any use case where it makes sense to have more than one icon for the 
_same_ application or file? i can't think of one. so i'd suggest just silently 
dropping duplicates.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090817/a480dddd/attachment.sig 


More information about the Plasma-devel mailing list