Review Request: plasma-netbook: missing kwin window decorations - fix for mid to netbook renaming

Roderick Greening roderick.greening at
Wed Aug 12 20:46:26 CEST 2009

This is an automatically generated e-mail. To reply, visit:

Review request for Plasma and Artur de Souza (MoRpHeUz).


As plasma-netbook was transitioned from being called MID to Netbook, not all things were updated to account for this. Specifically, in this case, was the minimal kwin window decorations for use in plasma-netbook. 

This patch updates the references to names, files, namespaces and classes to Netbook (from Mid).


  trunk/playground/base/plasma/netbook/kwin/CMakeLists.txt 1010511 
  trunk/playground/base/plasma/netbook/kwin/mid/CMakeLists.txt 1010511 
  trunk/playground/base/plasma/netbook/kwin/mid/mid.cpp 1010511 
  trunk/playground/base/plasma/netbook/kwin/mid/mid.desktop 1010511 
  trunk/playground/base/plasma/netbook/kwin/mid/mid.h 1010511 
  trunk/playground/base/plasma/netbook/kwin/netbook/CMakeLists.txt PRE-CREATION 
  trunk/playground/base/plasma/netbook/kwin/netbook/netbook.desktop PRE-CREATION 
  trunk/playground/base/plasma/netbook/kwin/netbook/netbook.h PRE-CREATION 
  trunk/playground/base/plasma/netbook/kwin/netbook/netbook.cpp PRE-CREATION 



This patch has been tested under Kubuntu Netbook Edition (KNE) which is under development (Karmic Koala 9.10 Alpha3), and does indeed provide the afore meantioned window decorations. 

I have tested min/max/move/resize of the window via the decorations and everything appears to be working as expected with no crashes.

The patch is a fairly simple one, only updating the names to the correct new naming scheme.



More information about the Plasma-devel mailing list