Review Request: Add HOME and END key navigation to folderview applet

[Shantanu Tushar Jha]

> On 2009-08-15 18:58:52, Artur de Souza (MoRpHeUz) wrote:
> > Why it doesn't make sense for a non sorted folder view ? Even if the items are not sorted, there is a "first item" and a "last item"...
> 
> Marco Martin wrote:
>     agree

Ok, so If in a unsorted view, HOME moves to the upper-left icon and END moved to the bottom-right icon, will that be the expected behaviour? Or will it have to take into account m_flow (which can be left to LeftToRight, TopToBottom, RightToLeft, TopToBottomRightToLeft) even in an unsorted view?


- Shantanu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1329/#review2035
-----------------------------------------------------------


On 2009-08-15 18:45:42, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1329/
> -----------------------------------------------------------
> 
> (Updated 2009-08-15 18:45:42)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This adds navigation support using the HOME and END keys. HOME moves to the first item, END moves to the last item.
> This applies only when the list is sorted, as in an unsorted view "start" and "end" do not make sense IMO. Let me know if this is right.
> 
> 
> This addresses bug 187241.
>     https://bugs.kde.org/show_bug.cgi?id=187241
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1011577 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1011577 
> 
> Diff: http://reviewboard.kde.org/r/1329/diff
> 
> 
> Testing
> -------
> 
> Tested when folderview is sorted using sort by Name, Type, Date etc. Works as expected.
> 
> 
> Thanks,
> 
> Shantanu
> 
>