Review Request: Plasma + QT Kinetic GSoC Project - Attempt 1

[makmanalp at wpi.edu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1320/
-----------------------------------------------------------

Review request for Plasma, Aaron Seigo and Alexis Menard.


Summary
-------

Hey,
Here's the current state of where I took my project. I'm sure that this isn't perfect enough to instantly merge into trunk, but it covers the requirements and works. I'll be working on it after GSoC ends until it gets in trunk and then I'll continue maintaining it, so I need the criticism to make it better and re-submit to review later.

Please read the FAQ [0] first, where I'll guide you though how everything works from start to finish. If you read that and check out the code at the same time, it'll save you a lot of time. Install instructions [1] are available so you can test. There's also a TODO [2] with some non-crucial stuff and some bugs (If you have any idea what's wrong with those, it'd be great to know). Finally, there's a sample plasmoid [3] but it's not nearly as good as it should be (sorry aseigo, couldn't get the chance for the cool demo). That's my next priority so we can show it off.

Oh, and I think I should mention that I moved animator.cpp to deprecated/animator.cpp and deprecated the old methods, it's not clear in the diffs.

[0] http://websvn.kde.org/branches/work/~makmanalp/FAQ?view=markup
[1] http://websvn.kde.org/branches/work/~makmanalp/INSTALL?view=markup
[2] http://websvn.kde.org/branches/work/~makmanalp/TODO?view=markup
[3] http://websvn.kde.org/branches/work/~makmanalp/sample/


Diffs
-----

  /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1011336 
  /trunk/KDE/kdelibs/plasma/animationelements.h PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/animationelements.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/animations/expand.h PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/animations/expand.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/animations/fade.h PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/animations/fade.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/animations/grow.h PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/animations/grow.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/animations/slide.h PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/animations/slide.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/animator.h 1011336 
  /trunk/KDE/kdelibs/plasma/animator.cpp 1011336 
  /trunk/KDE/kdelibs/plasma/deprecated/animator.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1320/diff


Testing
-------


Thanks,

makmanalp