[PATCH] BUG 203716 give user a hint when adding same application into quicklaunch

["潘卫平(Peter Pan)"]

Lukas Appelhans 写道:
> Am Freitag 14 August 2009 11:10:42 schrieb 潘卫平(Peter Pan):
>> Hi,all
>>
>> I think we should give user a hint when he/she adds a application which
>> already exists in quicklaunch, so I made this patch.
>>
>>
>> Regards
> Hey!
> 
> Good thing! But 2 things: I'm not 100% into the code currently, but why not 
> implementing the loop inside addProgram()?
>
In the beginning, I want to quit as soon as possible, to save CPU cycles.
But I agree that addProgram() is a more elegant place, but we should pay 
attention to initializing and sorting.

> And the second one: "Cancel or Continue?" is not needed as words inside the 
> MessageBox imo, as the buttons are named like it... "\"%1\" is already in 
> quicklaunch!"  should be enough!
> 

agree with you.
And I modify my patch.

> Regards,
> 
> Lukas
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel


-- 
潘卫平(Peter Pan)
Red Flag Software Co., Ltd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdebase-quicklaunch-same-application.patch
Type: text/x-patch
Size: 2921 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090814/83d7065b/attachment.patch