Review Request: plasma-netbook: fix for mid to netbook renaming

Roderick Greening roderick.greening at
Thu Aug 13 02:02:57 CEST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-08-13 00:02:57.317900)

Review request for Plasma and Artur de Souza (MoRpHeUz).


Updated to reflect current situation and testing.

Summary (updated)

As plasma-netbook was transitioned from being called MID to Netbook, not all things were updated to account for this. Specifically, in this case, was the minimal kwin window decorations for use in plasma-netbook. 

This patch updates the references to names, files, namespaces and classes to Netbook (from Mid).


  trunk/playground/base/plasma/netbook/kwin/CMakeLists.txt 1010511 
  trunk/playground/base/plasma/netbook/kwin/mid/CMakeLists.txt 1010511 
  trunk/playground/base/plasma/netbook/kwin/mid/mid.cpp 1010511 
  trunk/playground/base/plasma/netbook/kwin/mid/mid.desktop 1010511 
  trunk/playground/base/plasma/netbook/kwin/mid/mid.h 1010511 
  trunk/playground/base/plasma/netbook/kwin/netbook/CMakeLists.txt PRE-CREATION 
  trunk/playground/base/plasma/netbook/kwin/netbook/netbook.desktop PRE-CREATION 
  trunk/playground/base/plasma/netbook/kwin/netbook/netbook.h PRE-CREATION 
  trunk/playground/base/plasma/netbook/kwin/netbook/netbook.cpp PRE-CREATION 


Testing (updated)

The patch is a fairly simple one, only updating the names to the correct new naming scheme. Builds and compiles as it previously did.

Unfortunately, the window decoration is still broken, and does not load, which is the same behaviour exhibited when the plugin was called I expect there is some other issue preventing it from loading properly.

This patch is still necessary to move forward with the naming change.



More information about the Plasma-devel mailing list