Review Request: Simplest Image Hosting support for pastebin applet
Michal Dutkiewicz
emdeck at gmail.com
Mon Aug 10 18:41:16 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1251/
-----------------------------------------------------------
(Updated 2009-08-10 16:41:16.451067)
Review request for Plasma.
Changes
-------
Fixed showing error notification on success.
This was indeed second call of that method with empty data (strange, there should be no redirection, there was comment about that in imageshack backend).
Summary
-------
This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet.
Diffs (updated)
-----
/trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396
Diff: http://reviewboard.kde.org/r/1251/diff
Testing
-------
Works fine except showing error icon even if upload is successful (there is success notification and link is added to history).
Thanks,
Michal
More information about the Plasma-devel
mailing list