Review Request: activities support in opendesktop widget

[Marco Martin]

> On 2009-08-10 15:43:54, Chani wrote:
> > /trunk/KDE/kdeplasma-addons/applets/opendesktop/activitywidget.cpp, line 51
> > <http://reviewboard.kde.org/r/1253/diff/1/?file=9826#file9826line51>
> >
> >     just a little detail... using [] will create the key if it doesn't exist, so generally using .value("foo") is cheaper. probably doesn't matter in this case, just thought I'd point it out.

yeah, in this case ["message"] should always exist but good point


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1253/#review1957
-----------------------------------------------------------


On 2009-08-10 10:54:19, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1253/
> -----------------------------------------------------------
> 
> (Updated 2009-08-10 10:54:19)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> no, not plasma activities :p
> this adds the friends activity support to the opendesktop plasmoid and selects it by default, so it doesn't look as a static thing anymore but shows some "news"
> 
> still to do:
> configurable refresh time
> avatar pictures to make it more kolorful
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/opendesktop/CMakeLists.txt 1009325 
>   /trunk/KDE/kdeplasma-addons/applets/opendesktop/activitywidget.h PRE-CREATION 
>   /trunk/KDE/kdeplasma-addons/applets/opendesktop/activitywidget.cpp PRE-CREATION 
>   /trunk/KDE/kdeplasma-addons/applets/opendesktop/opendesktop.h 1009325 
>   /trunk/KDE/kdeplasma-addons/applets/opendesktop/opendesktop.cpp 1009325 
> 
> Diff: http://reviewboard.kde.org/r/1253/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/1253/s/170/
> 
> 
> Thanks,
> 
> Marco
> 
>