Review Request: Simplest Image Hosting support for pastebin applet

[Artur de Souza (MoRpHeUz)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1251/#review1950
-----------------------------------------------------------



/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp
<http://reviewboard.kde.org/r/1251/#comment1308>

    maybe you get the error post icon even after a successful post because it tries to retrieve more data and then you fall in this place. not sure though and right now I don't have the time to test. Check form where postError() is being emited on your backend code. (probably from here)



/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp
<http://reviewboard.kde.org/r/1251/#comment1309>

    Yes, we can remove all this dummy casts.



/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui
<http://reviewboard.kde.org/r/1251/#comment1310>

    With more plugins being added we need to properly fix this config tab now. We postponed this as much as we could but now we should do it properly. I'll come with something later (plane to tokamak? hehe).


- Artur


On 2009-08-09 21:08:23, Michal Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1251/
> -----------------------------------------------------------
> 
> (Updated 2009-08-09 21:08:23)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 
> 
> Diff: http://reviewboard.kde.org/r/1251/diff
> 
> 
> Testing
> -------
> 
> Works fine except showing error icon even if upload is successful (there is success notification and link is added to history).
> 
> 
> Thanks,
> 
> Michal
> 
>