Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs to be applied from kdeplasma-addons, hope it works for you.

[patcito at gmail.com]

> On 2009-08-09 22:59:47, Chani wrote:
> > looks good, only thing I can think of is we might want to hide the privacy option when imageshack is selected, since it doesn't apply to that site.
> > 
> > I assume you need someone to commit this for you? I've gotta run now, someone please take care of that :)

Hiding the privacy will be for next week I think :/ Otherwise you can commit as is for now, thanks for you help. By the way is there a minimum amount of patches I have to send before I can ask/get an svn account? :)


> On 2009-08-09 22:59:47, Chani wrote:
> > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt, line 12
> > <http://reviewboard.kde.org/r/1248/diff/2/?file=9813#file9813line12>
> >
> >     looks like you deleted this by accident

heh, yep fixed, thanks.


- patcito


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1248/#review1945
-----------------------------------------------------------


On 2009-08-09 22:00:52, patcito wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1248/
> -----------------------------------------------------------
> 
> (Updated 2009-08-09 22:00:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is my first patch, it just adds "posting private picture to
> imagebin.ca from the pastebin plasmoid" as the title says, it needs to
> be applied from kdeplasma-addons, hope it works for you.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008583 
> 
> Diff: http://reviewboard.kde.org/r/1248/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> now in the main config page
>   http://reviewboard.kde.org/r/1248/s/169/
> 
> 
> Thanks,
> 
> patcito
> 
>