[PATCH] BUG167947 pick a picture and set it as wallpaper in dolphin and konqueror

[Aaron J. Seigo]

On Thursday 06 August 2009, 潘卫平(Peter Pan) wrote:
> In KDE 3 , it was possible to set a wallpaper by dragging a picture from
> konqueror. And I implement this feature in Plasma::Containment.

i don't think this is really the right place for this code (in Containment); 
rather, i think this would be better implemented as an extension to Chani's 
containment actions project.

not all libplasma based applications will want to have images dropped on them 
setting the background, so this is really something that needs to be done per-
application. being able to define the default actions for dropped data 
therefore seems to make more sense.

also, just as an implementation note: 

+                    if (suffix == "png" || suffix == "jpg" || suffix == 
"jpeg" || suffix == "xcf"
+                                    || suffix == "svg" || suffix == "svgz")

it would probably be better to do a KMimeType based check :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090806/4934fbce/attachment.sig