Review Request: Quicklaunch: Fix bugs related to having unlimited visible icons

Shafqat Bhuiyan priomsrb at gmail.com
Mon Aug 3 02:13:19 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1220/
-----------------------------------------------------------

(Updated 2009-08-03 00:13:19.779107)


Review request for Plasma.


Changes
-------

Use static const int UNLIMITED_ICONS = -1


Summary
-------

This patch fixes a couple of bugs when having unlimited visible icons in the quicklaunch plasmoid.
They were:

- Having a vertical panel with unlimited number of icons resulted in just one row of squashed icons

- Having unlimited icons gives a bigger width for no reason

This should be backported to 4.3


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 1004927 

Diff: http://reviewboard.kde.org/r/1220/diff


Testing
-------

tested and compiled on trunk


Thanks,

Shafqat



More information about the Plasma-devel mailing list