Review Request: windows port of taskmanager library

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1101/#review1881
-----------------------------------------------------------



trunk/KDE/kdebase/workspace/libs/taskmanager/task.cpp
<http://reviewboard.kde.org/r/1101/#comment1229>

    Given there's a separate task_win.cpp, IMHO would be more clean adding Windows-specific includes only there.
    (The same could apply to the X11 headers for the _x11.cpp variant, but that can be done later.)



trunk/KDE/kdebase/workspace/libs/taskmanager/task_win.cpp
<http://reviewboard.kde.org/r/1101/#comment1226>

    I suppose those should be replaced by your copyright?



trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h
<http://reviewboard.kde.org/r/1101/#comment1228>

    This could go in, I'd say.


- Pino


On 2009-07-22 23:57:29, Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1101/
> -----------------------------------------------------------
> 
> (Updated 2009-07-22 23:57:29)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I want to add some missing functionality to the taskmanager library on the windows platform. As the code has some more X11 dependencies, I decided to make up two files for tasks.cpp which contain the functions that differ on Windows and X11.
> The only thing that should affect X11-builds in the end should be the change from class to struct for QUuid.
> There should be no other changes regarding the X11 platform.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/CMakeLists.txt 1000690 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/task.h 1000690 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/task.cpp 1000690 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/task_win.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/task_x11.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h 1000690 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.cpp 1000690 
> 
> Diff: http://reviewboard.kde.org/r/1101/diff
> 
> 
> Testing
> -------
> 
> I tested this on windows with both gcc and msvc compilers.
> 
> 
> Thanks,
> 
> Patrick
> 
>