Review Request: gsoc mouse plugins: the plugins!
Chani
chanika at gmail.com
Sat Aug 1 03:42:18 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1200/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
this is the last of three patches I've finally persuaded reviewboard to accept.
it contains all the actual plugins. :)
there are 6 plugins in there:
-test: just a dummy to help me test stuff. should be removed from CMakeLists.txt once I'm done, I assume.
-zoom: this one isn't done, it's on hold until the ZUI/Overview stuff is sorted. ignore it.
-switchactivity: switches activity. works with scrollwheel or buttons.
-switchdesktop: switches desktop. very similar to switchactivity.
-paste: acts like you drag&dropped whatever's on the mouse clipboard. defaults to middle-button of course; it's here so it can be disabled like any other mouse action.
-contextmenu: shows the old contextmenu we all know and love. ;) it's also got a bit of configurability now.
with that plugin I've also stripped a lot of code out of the desktop and panel containments.
for more details see http://gitorious.org/plasma-mouse-plugins/kdebase-workspace-plasma/commits/gsoc and other branches. gsoc has the squashed commits, and master is just trunk with none of my changes.
known issues:
-panel containment still has its own config action. I don't like that but I haven't come up with a good way to make all the code happy.
-the switcher plugins don't implement contextualActions (in fact, only contextmenu does). I realised it'd be a lot more work to make it work as just a list of actions without a menu under the plugin's control.
-all existing containments not in workspace will have duplicate contextualactions until they're updated. that's the responsibility of whoever wrote those containments, though.
Diffs
-----
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/CMakeLists.txt 1005079
/trunk/KDE/kdebase/workspace/plasma/containments/desktop/CMakeLists.txt 1005079
/trunk/KDE/kdebase/workspace/plasma/containments/desktop/desktop.h 1005079
/trunk/KDE/kdebase/workspace/plasma/containments/desktop/desktop.cpp 1005079
/trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp 1005079
/trunk/KDE/kdebase/workspace/plasma/contextactions/CMakeLists.txt PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/contextactions/contextmenu/CMakeLists.txt PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/contextactions/contextmenu/menu.h PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/contextactions/contextmenu/menu.cpp PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/contextactions/contextmenu/plasma-contextaction-contextmenu.desktop PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/contextactions/paste/CMakeLists.txt PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/contextactions/paste/paste.h PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/contextactions/paste/paste.cpp PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/contextactions/paste/plasma-contextaction-paste.desktop PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/contextactions/switchactivity/CMakeLists.txt PRE-CREATION
/trunk/KDE/kdebase/workspace/plasma/contextactions/switchactivity/plasma-contextaction-switchactivity.desktop PRE-CREATION
Diff: http://reviewboard.kde.org/r/1200/diff
Testing
-------
Screenshots
-----------
Switch Activity on a button
http://reviewboard.kde.org/r/1200/s/161/
Context Menu, customized
http://reviewboard.kde.org/r/1200/s/162/
Context Menu through an applet
http://reviewboard.kde.org/r/1200/s/163/
Context Menu config UI
http://reviewboard.kde.org/r/1200/s/164/
Thanks,
Chani
More information about the Plasma-devel
mailing list