Review Request: Make "Cycle desktop on mouse wheel" and optional feature on the Pager plasmoid

[Aaron Seigo]

> On 2009-04-29 10:12:22, Aaron Seigo wrote:
> > i don't think this belongs in the pager: the desktop view and the taskbar also implement the same scroll wheel features. this really sounds like something that ought to be put into the mythical global plasma-desktop kcm
> 
> Darío Andrés wrote:
>     I guess it could make sense to make it a global setting as it would weird if you disabled desktop cycling when wheeling on the desktop and you want it to be in the pager instead. 
>     But, about the Taskbar... at least here, the mouse wheel action only cycle through the opened applications in the taskbar itself, so I think it's another (different) action. May be in that case a specific configuration option could be added to the taskbar. (I couldn't find the code of the wheelEvent on the taskbar.... may be I got it all wrong)
>     
>     Regards
>     Dario

i find that people that don't like one don't like the other, usually because they are using a crappy pointer device or a pointer device with a crappy driver or a pointer device with a crappy configuration. i don't think we need N different configuration switches for this. one shoudl be enough. we can always refine it later and add more if needed, but we can't take configuration options we offer in a release back without some serious backlash.

(been there, done that, starting with the "icon zooming" thing in kde3)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/641/#review1001
-----------------------------------------------------------


On 2009-04-29 07:07:20, Darío Andrés wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/641/
> -----------------------------------------------------------
> 
> (Updated 2009-04-29 07:07:20)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Make "Cycle desktop on mouse wheel" and optional feature on the Pager plasmoid. Addresses part of bug 187487
> I don't know if anything else is needed when adding a new configuration entry. It sets the default(and current) value on constructor.
> BTW-offtopic: the Pager plasmoid config dialog may need a relayouting.
> 
> 
> This addresses bug 187487.
>     https://bugs.kde.org/show_bug.cgi?id=187487
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.h 960693 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp 960693 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/pager/pagerConfig.ui 960693 
> 
> Diff: http://reviewboard.kde.org/r/641/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darío
> 
>