Review Request: Context menu for fast copying date and time strings to clipboard (libplasmaclock)

Aaron Seigo aseigo at kde.org
Mon Apr 20 17:49:41 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/521/#review972
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp
<http://reviewboard.kde.org/r/521/#comment666>

    qobject_cast<QWidget*>(this) will return 0; this is not a QWidget :)
    
    you will need to manage the memory of this one manually and delete d->clipboardMenu in the destructor.


- Aaron


On 2009-04-20 03:16:22, Michal Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/521/
> -----------------------------------------------------------
> 
> (Updated 2009-04-20 03:16:22)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch tries to add context menu with formatted date and time strings to clocks (by adding it to plasmaclock library) like in KDE3.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 956306 
>   /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 956306 
> 
> Diff: http://reviewboard.kde.org/r/521/diff
> 
> 
> Testing
> -------
> 
> Tested using digital-clock and analog-clock applets from trunk and it works fine.
> 
> 
> Thanks,
> 
> Michal
> 
>



More information about the Plasma-devel mailing list