Review Request: Ported korgac systray to KNotificationAreaItem

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/601/#review950
-----------------------------------------------------------



/trunk/KDE/kdepim/korganizer/korgac/alarmdockwindow.h
<http://reviewboard.kde.org/r/601/#comment648>

    Where would that file be?
    I updated kdelibs to be sure to have most recent trunk, but find . -name "knotificationareaitem.h" does not find anything



/trunk/KDE/kdepim/korganizer/korgac/alarmdockwindow.h
<http://reviewboard.kde.org/r/601/#comment649>

    Is this an override from KNotificationAreaItem? Or any other reason why it is marked virtual?
    
    If it is from KNotificationAreaItem, is that class really that badly designed that it doesn't have const QPoint&?
    



/trunk/KDE/kdepim/korganizer/korgac/alarmdockwindow.cpp
<http://reviewboard.kde.org/r/601/#comment650>

    Any reason the already loaded icon is not used like before?



/trunk/KDE/kdepim/korganizer/korgac/alarmdockwindow.cpp
<http://reviewboard.kde.org/r/601/#comment651>

    Shouldn't that connect a different signal now?
    The slot does not exist anymore



/trunk/KDE/kdepim/korganizer/korgac/alarmdockwindow.cpp
<http://reviewboard.kde.org/r/601/#comment652>

    See above



/trunk/KDE/kdepim/korganizer/korgac/koalarmclient.cpp
<http://reviewboard.kde.org/r/601/#comment653>

    Can the KNotificationAreaItem be hidden?


- Kevin


On 2009-04-17 12:39:18, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/601/
> -----------------------------------------------------------
> 
> (Updated 2009-04-17 12:39:18)
> 
> 
> Review request for KDE PIM and Plasma.
> 
> 
> Summary
> -------
> 
> Ported korgac systray to KNotificationAreaItem
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/korganizer/korgac/CMakeLists.txt 955378 
>   /trunk/KDE/kdepim/korganizer/korgac/alarmdockwindow.h 955378 
>   /trunk/KDE/kdepim/korganizer/korgac/alarmdockwindow.cpp 955378 
>   /trunk/KDE/kdepim/korganizer/korgac/koalarmclient.cpp 955378 
> 
> Diff: http://reviewboard.kde.org/r/601/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>