Review Request: Ported kopete systray icon to KNotificationAreaItem.

[F. Yilmaz]

Tnx : )

Weer goed werk geleverd. Ik val je weer lastig zodra ik een nieuwe opdracht
krijg : )


Mvg,
Fatih

2009/4/18 Marco Martin <notmart at gmail.com>

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/603/#review955
> -----------------------------------------------------------
>
>
> with the premise that i don't know kopete enough, it seems good to me and
> seems to work quite good.
> tough it opens two questions:
> -hiding: should be a function in the api to hide the icon? (i would say if
> you want to completely remove the icon, delete the knotificationareaitem
> instance, but seems tricky in this kopete example..)
>
> -overlays: many apps, like kopete here seems to use composite icons to show
> status, overlays and things like that, so of course they all have to
> fallback at the pixmap method.. could be provided some facility in the
> protocol (i.e setOverlayIcon) or (as i propend now) anyways eveyone will
> want to do -slightly- different so in the end pixmaps will be used anyways?
>
> - Marco
>
>
> On 2009-04-17 15:06:26, Davide Bettio wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/603/
> > -----------------------------------------------------------
> >
> > (Updated 2009-04-17 15:06:26)
> >
> >
> > Review request for Kopete and Plasma.
> >
> >
> > Summary
> > -------
> >
> > Ported kopete systray icon to KNotificationAreaItem.
> >
> >
> > Diffs
> > -----
> >
> >   /trunk/KDE/kdenetwork/kopete/kopete/CMakeLists.txt 955509
> >   /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 955509
> >   /trunk/KDE/kdenetwork/kopete/kopete/systemtray.h 955509
> >   /trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp 955509
> >
> > Diff: http://reviewboard.kde.org/r/603/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Davide
> >
> >
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20090419/8b71bebf/attachment-0001.htm