Review Request: Change behavior of "windows can cover" option

[Stefanos Harhalakis]

> On 2009-04-16 13:05:16, Aaron Seigo wrote:
> > tags/KDE/4.2.2/kdebase/workspace/plasma/shells/desktop/panelview.cpp, lines 1131-1138
> > <http://reviewboard.kde.org/r/597/diff/1/?file=5434#file5434line1131>
> >
> >     this code should be moved to hideMousePoll()

This was that way. I suggest that I leave it as-is and it is latter changed. Just to don't make the patch touch things that aren't related to what it does. Also, are you sure that this doesn't introduce and bugs? m_triggerEntered will be delayed to be cleared.


> On 2009-04-16 13:05:16, Aaron Seigo wrote:
> > tags/KDE/4.2.2/kdebase/workspace/plasma/shells/desktop/panelview.cpp, line 1140
> > <http://reviewboard.kde.org/r/597/diff/1/?file=5434#file5434line1140>
> >
> >     the && should be on the line above (just how we roll :)

OK. done.


- Stefanos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/597/#review939
-----------------------------------------------------------


On 2009-04-16 11:23:19, Stefanos Harhalakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/597/
> -----------------------------------------------------------
> 
> (Updated 2009-04-16 11:23:19)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Make "windows can cover" option to lower the panel when the mouse pointer is left.
> 
> 
> Diffs
> -----
> 
>   tags/KDE/4.2.2/kdebase/workspace/plasma/shells/desktop/panelview.cpp 954992 
> 
> Diff: http://reviewboard.kde.org/r/597/diff
> 
> 
> Testing
> -------
> 
> Seems to work.
> 
> 
> Thanks,
> 
> Stefanos
> 
>