Review Request: Add city and country resolution to GPS geolocation data using geonames.

[Andrew Coles]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/592/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Yesterday, I proposed a patch for using an IP geolocation service that returns longitude and latitude, as the GPS backend would give that data but the IP one would not.  Today, it's the other way around: a patch to add place name and country information to the GPS geolocation data, as the IP geolocation gives this but GPS geolocation does not.

The only caveat is that I'm programming blind - I don't have a GPS receiver, and 'it compiles' is far from good enough.  Hence, I need a volunteer to test it - anyone?

Assuming it works, the geolocation data engine will then have reached the point where the fields returned are identical, /irregardless of whether IP or GPS data is used/.  Specifically, the user gets:

- Latitude
- Longitude
- Accuracy
- Country Name
- Country Code
- City Name


Diffs
-----

  /trunk/kdereview/plasma/dataengines/geolocation/location_gps.h 954031 
  /trunk/kdereview/plasma/dataengines/geolocation/location_gps.cpp 954031 

Diff: http://reviewboard.kde.org/r/592/diff


Testing
-------

It compiles, and it looks alright.  How pitiful is that?  Given it's based on the IP geolocation XML code, but using a reverse geocoding rather than IP geolocation service, it should in theory work, but it really does need testing by someone with a GPS unit.


Thanks,

Andrew