Review Request: Patch to use the iplocationtools.com geolocation service (lat/long information, bigger database)

Andrew Coles andrew_coles at yahoo.co.uk
Tue Apr 14 12:43:14 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/584/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Patch to use the iplocationtools.com geolocation service with the geolocation DataEngine.  Motivation is two-fold:

 i) Better database (selfishly, it now works for me ;) )
ii) Service returns latitude/longitude information - just as the GPS back-end does - so anything using geolocation has a common denominator to work with, rather than GPS returning lat/long and IP returning a place name.


Diffs
-----

  /trunk/kdereview/plasma/dataengines/geolocation/location_ip.h 953569 
  /trunk/kdereview/plasma/dataengines/geolocation/location_ip.cpp 953569 

Diff: http://reviewboard.kde.org/r/584/diff


Testing
-------


Thanks,

Andrew



More information about the Plasma-devel mailing list