KDE/kdebase/apps/plasma/applets/folderview

[Aaron J. Seigo]

On Thursday 09 April 2009, Fredrik Höglund wrote:
> SVN commit 951572 by fredrik:
>
> Include actions in the drop menu for creating applets for the dropped
> URL's, and for setting the wallpaper.

this is broken in so many ways:

* it assumes there's an Image plugin on the system

* it assumes Image has a mode called SingleImage

* it assumes that the dropped file should actually be used with the Image 
plugin, when really if i drop an image and i'm using the Virus paper (for 
instance) it should change the image file used by Virus without switching to 
Image

* it creates a behaviour that is only found in one containment when really 
this should probably be found in all Containments where drawWallpaper()

* it prevents drops of files creating widgets such as the Frame widget (though 
in this case, that may be warranted / desired given that it's a "compatibility 
mode" containment?)

* it contains assumptions about how the configuration is stored for the Image 
plugin; changes in the Image plugin or how Containment deals with wallpaper 
config data can and will break this.

* does it actually do this when it's a widget and not a containment?

the way this ought to be done is to have Wallpapers register supported 
mimetypes in their .desktop file and query these on file drops and merge those 
possibilities with the menu created in the KUrl::List::canDecode(event-
>mimeData()) branch in Containment::dropEvent

please revert this particular commit and let's do it properly.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090412/f95896ed/attachment.sig