Review Request: QTimer and Event compression

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/538/#review887
-----------------------------------------------------------


the timer should be a single shot timer, otherwise it will keep firing over and over and over.

now we need to know if it's being effective or not :) in your local copy, try putting a kDebug(); line where the timer is started and one in refactorUi() to see how many times each is called as you resize the applet on the desktop. this should help you determine if the timer delay (100) is enough.

- Aaron


On 2009-04-09 08:16:50, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/538/
> -----------------------------------------------------------
> 
> (Updated 2009-04-09 08:16:50)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> Hi Aron,
> 
> This review request is regarding the event compression and 
> QTimer of quicklaunch, which you had discussed in the IRC. 
> I had given m_timer->start(100). I hope I am correct. If I 
> am wrong then please do correct me.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 950296 
>   /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 950296 
> 
> Diff: http://reviewboard.kde.org/r/538/diff
> 
> 
> Testing
> -------
> 
> Just compiled the quicklaunch. It compiled without any issues.
> 
> 
> Thanks,
> 
> Sujith
> 
>