Review Request: Add a "Windows should cover" option to plasma panels.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/537/#review867
-----------------------------------------------------------


what's the benefit over "Windows can cover"? that you don't have to click on a window to hide the panel beneath it? or versus autohide, where the only difference is when you don't have any windows obscuring the screen edge the panel is on? i'm concerned that adding a 5th option here we certainly will have covered every possible twisting and turning of it, but is there a real benefit to doing this or are we just adding to the list of options to choose from?

- Aaron


On 2009-04-07 17:15:14, Stefanos Harhalakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/537/
> -----------------------------------------------------------
> 
> (Updated 2009-04-07 17:15:14)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add a "Windows should cover" option to plasma panels. This makes the panel auto-lower itself and raise when the mouse touches the appropriate screen edge. It's like an intermediate of "auto-hide" and "windows can cover". This way it is possible to have a visible panel when you have free space at the bottom of the screen, but make full screen windows cover the panel when they're maximized. Helps a lot for laptops with 16:9 screens where there isn't much available height.
> 
> 
> Diffs
> -----
> 
>   /tags/KDE/4.2.2/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp 950760 
>   /tags/KDE/4.2.2/kdebase/workspace/plasma/shells/desktop/panelview.h 950760 
>   /tags/KDE/4.2.2/kdebase/workspace/plasma/shells/desktop/panelview.cpp 950760 
> 
> Diff: http://reviewboard.kde.org/r/537/diff
> 
> 
> Testing
> -------
> 
> Seems to work. No more testing. There may be performed redundant actions.
> 
> 
> Thanks,
> 
> Stefanos
> 
>