Review Request: Solar position calculation to time dataengine

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/536/#review859
-----------------------------------------------------------

Ship it!


looks good; as for the I18N_NOOPs, the idea was that users of DataEngines could then just show the key/value pairs directly in a user interface and get them translated without having to know the keys ahead of time. i expect this to become an issue when we have more scripted plasmoids; others don't seem to think it matters. *shrug*

- Aaron


On 2009-04-07 07:40:14, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/536/
> -----------------------------------------------------------
> 
> (Updated 2009-04-07 07:40:14)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Integrate solarposition dataengine to time dataengine. Why time datengine uses I18N_NOOPs (Applets don't)?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/CMakeLists.txt 950075 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarposition.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarposition.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.h 950075 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.cpp 950075 
> 
> Diff: http://reviewboard.kde.org/r/536/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>