Review Request: Makes the configuration of the comic plasmoid easier to use

Matthias Fuchs mat69 at gmx.net
Tue Apr 7 15:09:39 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/461/
-----------------------------------------------------------

(Updated 2009-04-07 06:09:38.940725)


Review request for Plasma and Davide Bettio.


Changes
-------

Adds checkboxes for the treeview (inherited from QAbstractTableModel). Puts configuration options into form layouts and some other minor changes -- see screenshots.


Summary
-------

Whenever the user ticks "Use Tabs" the view changes and the available comics are displayed in a listview, clicking at them marks them and adds them as tabs if ok is pressed. Otherwise it is similar to the current situation.

I'm not sure if I should add "Select All"-, "Deselect All"-Buttons. What do you think?


Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/applets/comic/appearanceSettings.ui 950532 
  /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 950532 
  /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 950532 
  /trunk/KDE/kdeplasma-addons/applets/comic/comicSettings.ui 950532 
  /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h 950532 
  /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp 950532 

Diff: http://reviewboard.kde.org/r/461/diff


Testing
-------


Screenshots (updated)
-----------


  http://reviewboard.kde.org/r/461/s/99/

  http://reviewboard.kde.org/r/461/s/100/

  http://reviewboard.kde.org/r/461/s/102/


Thanks,

Matthias



More information about the Plasma-devel mailing list