solarposition dataengine moved to kdereview

[Aaron J. Seigo]

On Monday 06 April 2009, Petri Damstén wrote:
> On Monday 06 April 2009 18:27:35 Aaron J. Seigo wrote:
> > On Monday 06 April 2009, Petri Damstén wrote:
> > > - In weather station to accurately detect if it's night or day.
> >
> >  would it make sense to add this to the time engine?
>
> Doesn't adding solar position calculation to time engine complicate it too
> much?

depends on how it's done, of course.

if the solar sources started with "Solar:" then it would be easy to sort out 
which path to go, and if all the parsing was put into a helper class it would 
keep the TimeEngine class itself quite clean.

the question is whether this is "time" data or not. if it is time data, it 
should go into the time engine. the user of a DataEngine should not really 
have to care about where data comes from but just the kind of information they 
are after.

i'm quite fine with it being in a separate DataEngine, but was curious as to 
whether this is "time" information or something conceptually different.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090406/3d1b5108/attachment.sig