Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)

Sujith H sujith.h at gmail.com
Sat Apr 4 09:52:01 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/
-----------------------------------------------------------

(Updated 2009-04-04 00:52:01.302069)


Review request for Plasma.


Changes
-------

I had made the nameDisplayOrder return ApplicationModel::DisplayOrder.


Summary
-------

As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see "Audio Player - Amarok". But he requested it to be in other way "Amarok - Audio Player". Hence as an initial step he asked me to add a check box similar to "Switch tabs on hover". I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 
  /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 
  /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 947244 
  /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 
  /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 

Diff: http://reviewboard.kde.org/r/441/diff


Testing
-------

I had compiled the above patch in my build directory. It compiled without any errors. 


Thanks,

Sujith



More information about the Plasma-devel mailing list