Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
Sujith H
sujith.h at gmail.com
Fri Apr 3 20:13:03 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review806
-----------------------------------------------------------
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp
<http://reviewboard.kde.org/r/441/#comment493>
I believe this method fits here. Is this method wrong?
- Sujith
On 2009-04-02 12:34:04, Sujith H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/441/
> -----------------------------------------------------------
>
> (Updated 2009-04-02 12:34:04)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see "Audio Player - Amarok". But he requested it to be in other way "Amarok - Audio Player". Hence as an initial step he asked me to add a check box similar to "Switch tabs on hover". I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 947244
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244
>
> Diff: http://reviewboard.kde.org/r/441/diff
>
>
> Testing
> -------
>
> I had compiled the above patch in my build directory. It compiled without any errors.
>
>
> Thanks,
>
> Sujith
>
>
More information about the Plasma-devel
mailing list