Review Request: IconWidget Drag&Drop visual feedback.
Aaron Seigo
aseigo at kde.org
Thu Apr 2 20:07:28 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/507/#review788
-----------------------------------------------------------
Ship it!
one very minor change, but then it's good to go!
trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp
<http://reviewboard.kde.org/r/507/#comment476>
this should probably be left up to the user of the IconWidget; by default, the icon widget doesn't actually do anything with drops and we don't suddenly want every icon looking like it does ;)
- Aaron
On 2009-04-02 10:53:58, Davide Bettio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/507/
> -----------------------------------------------------------
>
> (Updated 2009-04-02 10:53:58)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Use the hover background also for the drag&drop.
>
>
> This addresses bug 110952.
> https://bugs.kde.org/show_bug.cgi?id=110952
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/plasma/widgets/iconwidget.h 948167
> trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp 948167
>
> Diff: http://reviewboard.kde.org/r/507/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Davide
>
>
More information about the Plasma-devel
mailing list