Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review785
-----------------------------------------------------------


getting closer :)


/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
<http://reviewboard.kde.org/r/441/#comment469>

    this is still calling the wrong method. it shouldn't be calling switchTabsOnHover, it should be calling d->launcher->showAppsByName();



/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
<http://reviewboard.kde.org/r/441/#comment470>

    this will create a new ApplicationModel object, not modify the one that is actually in use already.
    
    there is an ApplicationModel object created earlier in this file; that object should be kept in a member variable (e.g. m_applicationModel) and used here.



/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
<http://reviewboard.kde.org/r/441/#comment471>

    this should be:
    
    return m_applicationModel->nameDisplayOrder() == ApplicationModel::NameBeforeDescription;



/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
<http://reviewboard.kde.org/r/441/#comment472>

    don't need this line.


- Aaron


On 2009-04-02 09:33:32, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/441/
> -----------------------------------------------------------
> 
> (Updated 2009-04-02 09:33:32)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see "Audio Player - Amarok". But he requested it to be in other way "Amarok - Audio Player". Hence as an initial step he asked me to add a check box similar to "Switch tabs on hover". I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 947244 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 
> 
> Diff: http://reviewboard.kde.org/r/441/diff
> 
> 
> Testing
> -------
> 
> I had compiled the above patch in my build directory. It compiled without any errors. 
> 
> 
> Thanks,
> 
> Sujith
> 
>