Review Request: Add support for KUrl config values in javascript

[Petri Damstén]

> On 2009-04-01 11:48:20, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.h, line 52
> > <http://reviewboard.kde.org/r/496/diff/1/?file=4641#file4641line52>
> >
> >     maybe a good opportunity to get rid of the '2' in the name and just make it variantToScriptValue everywhere.

renamed to variantToScriptValue


> On 2009-04-01 11:48:20, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.cpp, line 113
> > <http://reviewboard.kde.org/r/496/diff/1/?file=4642#file4642line113>
> >
> >     how about QUrl too?

Added QUrl and QColor


> On 2009-04-01 11:48:20, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.cpp, line 757
> > <http://reviewboard.kde.org/r/496/diff/1/?file=4642#file4642line757>
> >
> >     this could just become a (static?) member of the class instead of having a member method that calls a file global function?

AppletInterface needs non static and other global functions need static/global version.


- Petri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/496/#review777
-----------------------------------------------------------


On 2009-04-01 06:51:44, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/496/
> -----------------------------------------------------------
> 
> (Updated 2009-04-01 06:51:44)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add support for KUrl config values. Needed e.g. if ui file has KUrlRequester.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/appletinterface.h 947782 
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/appletinterface.cpp 947782 
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.h 947782 
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.cpp 947782 
> 
> Diff: http://reviewboard.kde.org/r/496/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>