Review Request: function to retrieve the cached rendered panelsvg

Aaron Seigo aseigo at kde.org
Tue Sep 30 22:44:21 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/208/#review212
-----------------------------------------------------------

Ship it!


yep, this one is an easy Ship It! =)

- Aaron


On 2008-09-30 13:23:31, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/208/
> -----------------------------------------------------------
> 
> (Updated 2008-09-30 13:23:31)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> PanelSvg::panelPixmap coherent with Svg::pixmap to easily access the cached panel. it would make the code of animation using paintutils::transition a lot simpler, now i know it's a question of api size vs code using it size, hmm..
> btw i think could lead to a cleaner code since animations are used quite often
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/panelsvg.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/panelsvg.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/208/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Plasma-devel mailing list