Review Request: Tasks-refactor: show group in popup menu

[Christian Mollekopf]

i think the menu should not appear without a delay since this makes it impossible to manually sort items without defining some special button (like alt for grouping).

I would actually prefer if you didn't commit yet marco, because i've got some multirow support in stock. Would be great if i could commit this first =) (i have already included your stuff anyway)

However i would suggest that we can get a normal taskmenu with rightclick on the task in the popup menu.

Therefore i will add a new menu to taskactions.h in the lib because this could probably be used by every visualization with grouping support.

Middleclick for expanding is a good idea as i think. 

So as a conclusion for the controls that i would consider usable:

-mousepress on group pops up group popup after a little delay

-rightclick shows the normal menu (also in the popup menu)

-manual sorting is done without any special key

-manual grouping is done by pressing the alt key (how can we tell the user?)

-middle click expands a group or collapses parent group if executed on grouped task


Regards,

Christian












> Subject: Re: Review Request: Tasks-refactor: show group in popup menu
> From: aseigo at kde.org
> To: plasma-devel at kde.org; notmart at gmail.com; aseigo at kde.org
> Date: Tue, 30 Sep 2008 16:19:16 +0000
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/204/#review210
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> good idea; perhaps improvable with comment below?
> 
> 
> /trunk/playground/base/plasma/applets/tasks-refactor/abstracttaskitem.cpp
> <http://reviewboard.vidsolbach.de/r/204/#comment174>
> 
> i wonder if middle click shouldn't expand the group as double clicking did, and mouse wheel scroll through the entries?
> 
> 
> - Aaron
> 
> 
> On 2008-09-27 07:09:22, Marco Martin wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.vidsolbach.de/r/204/
> > -----------------------------------------------------------
> > 
> > (Updated 2008-09-27 07:09:22)
> > 
> > 
> > Review request for Plasma.
> > 
> > 
> > Summary
> > -------
> > 
> > shows the group components in a simple QMenu upon mouse press and activate tasks also when middle button is pressed. so this restores exactly the behaviour of kde3: popup with left button and cycle group components with middle button.
> > probably this should become something based on Plasma::Dialog and graphicswidgets, but let's make it work before maing it pretty :p
> > the positioning is also a bit dumb, probably abstracttaskitems will need something like Applet::popupPosition()
> > 
> > 
> > Diffs
> > -----
> > 
> > /trunk/playground/base/plasma/applets/tasks-refactor/abstracttaskitem.cpp
> > /trunk/playground/base/plasma/applets/tasks-refactor/taskgroupitem.h
> > /trunk/playground/base/plasma/applets/tasks-refactor/taskgroupitem.cpp
> > 
> > Diff: http://reviewboard.vidsolbach.de/r/204/diff
> > 
> > 
> > Testing
> > -------
> > 
> > 
> > Thanks,
> > 
> > Marco
> > 
> >
> 
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
-- 
Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger