Review Request: Tasks-refactor: show group in popup menu

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/204/#review210
-----------------------------------------------------------

Ship it!


good idea; perhaps improvable with comment below?


/trunk/playground/base/plasma/applets/tasks-refactor/abstracttaskitem.cpp
<http://reviewboard.vidsolbach.de/r/204/#comment174>

    i wonder if middle click shouldn't expand the group as double clicking did, and mouse wheel scroll through the entries?


- Aaron


On 2008-09-27 07:09:22, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/204/
> -----------------------------------------------------------
> 
> (Updated 2008-09-27 07:09:22)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> shows the group components in a simple QMenu upon mouse press and activate tasks also when middle button is pressed. so this restores exactly the behaviour of kde3: popup with left button and cycle group components with middle button.
> probably this should become something based on Plasma::Dialog and graphicswidgets, but let's make it work before maing it pretty :p
> the positioning is also a bit dumb, probably abstracttaskitems will need something like Applet::popupPosition()
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/base/plasma/applets/tasks-refactor/abstracttaskitem.cpp
>   /trunk/playground/base/plasma/applets/tasks-refactor/taskgroupitem.h
>   /trunk/playground/base/plasma/applets/tasks-refactor/taskgroupitem.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/204/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>