Review Request: Style non-editable comboboxes like a Plasma::Button

Aaron Seigo aseigo at kde.org
Tue Sep 30 17:57:18 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/206/#review208
-----------------------------------------------------------

Ship it!


nice =)

- Aaron


On 2008-09-28 05:10:42, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/206/
> -----------------------------------------------------------
> 
> (Updated 2008-09-28 05:10:42)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> the combobox in battery applet popup looked a bit out of place, so now it's just as the Plasma::Button with the same svg and animated
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/combobox.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/combobox.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/206/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.vidsolbach.de/r/206/s/70/
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Plasma-devel mailing list