playground/base/plasma/applets/systray-refactor/protocols/plasmoid

[Sebastian Kügler]

Let's move this to plasma-devel ...

On Saturday 20 September 2008 12:41:09 you wrote:
> Sebastian Kügler wrote:
> > On Friday 19 September 2008 10:19:24 Jason Stubbs wrote:
> >> On Fri, Sep 19, 2008 at 11:35 AM, Sebastian Kügler <sebas at kde.org> wrote:
> >>> +        // The applet does need a size, otherwise it won't show up
> >>> correctly.
> >>> +        applet->setMinimumSize(22, 22);
> >>
> >> I was thinking about this too after noticing that the battery applet was
> >> sometimes 1 pixel wide. ;)  I wonder if there's not a way to do it at a
> >> higher level though. The one thing that concerns me is if an applet
> >> wants to (or already has) set its own minimum size. Perhaps the 22x22
> >> minimum size should be done in CompactLayout? I'm not too sure about the
> >> dos and don'ts of custom layouts...
> >
> > Yeah, this is the "lazy bum" version. We should definitely solve this at
> > a highler level. The plasmoids support in the systray needs I think two
> > more bits of information from the systray applet, itemsize (that's 22x22
> > when there are FDO-systray tasks in there), and $another_size (when there
> > are only plasmoids in the systray, those are freely resizable).
>
> There's no need for all items to all be the same size. Thinking about
> it, I think it might be best to use each items minimum size rather than
> preferred size and ensure that items aren't set smaller than 22x22.

Yup, setting minimumSize() should be sufficient for the cases I encountered.

> > The applets should also be told about the formfactor by the systray
> > applet
> >
>  > (I think horizontal makes sense in almost all cases).
>
> This will require SystemTray::Task to return something other than a
> QGraphicsWidget* as the design intentionally allows a Task to be
> displayed in several trays and each may have a different orientation.

Then we should have different applets displaying -- applets are meant to be 
this visualisation. The applet decides based on size and formfactor how to 
display. 

> > They should also be restricted to square, for simplicity (laziness).
>
> This also seems to be an arbitrary restriction. CompactLayout already
> supports items of arbitrary sizes and ensures items don't overlap
> without taking up too much space. There's definitely a lot of room for
> improvement, but I don't think that's a good reason for such a restriction.

I didn't know the layout was that smart. Good then :)

> > Also, I think it goes wrong (crash) as soon as the applet tries to access
> > a containment, and some applets also don't show up (tried notify and
> > kuiserver, both leave a black spot, but no icons on the tray).
>
> These sound like issues with the individual applets, but I can take a
> look at some time... I'd really prefer to stay focused on getting
> regular system tray icons working perfectly and getting notify
> integrated before 4.2 though.

Yes, regular systray icons and notify have priority. :)
I was actully playing around with the notify applet, just loading it into the 
systray and see if it gets hidden properly -- I wanted to check if the 
notifications get displayed even when the icon is hidden. But it doesn't show 
up in the first place...

Thanks for the insight,
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080920/f8fc04e0/attachment.sig