Review Request: use plasma theme icons for panel move and resize

[Marco Martin]

On Friday 19 September 2008, Aaron Seigo wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/197/#review204
> -----------------------------------------------------------
>
> Ship it!
>
>
> this patch does make me realize something though: it would make lots of
> sense to make Plasma::Svg return a QPixmap, which would usually be pulled
> right out of the cache, instead of requiring a painter. this would
> eliminate in this case at least two pixmap creations (x server roundtrips,
> no less)
you know what? completely agree, i'll give a shot right now, but the returned 
pixmap should be a copy right? bit unconfortable to give the possibility to 
mess up in the cache even if it's faster.

Cheers,
Marco Martin

>
> - Aaron
>
> On 2008-09-19 09:03:12, Marco Martin wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.vidsolbach.de/r/197/
> > -----------------------------------------------------------
> >
> > (Updated 2008-09-19 09:03:12)
> >
> >
> > Review request for Plasma.
> >
> >
> > Summary
> > -------
> >
> > uses the plasma themed svg icons as icons for the panel posiztion and
> > panel resize buttons in panelcontroller, to have a coherent look with the
> > applet handle (we also had the similar problem of a resize icon not
> > really suitable here) as usual graphics is temporary btw :)
> >
> >
> > Diffs
> > -----
> >
> >   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.h
> >   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp
> >
> > Diff: http://reviewboard.vidsolbach.de/r/197/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Screenshots
> > -----------
> >
> >
> >   http://reviewboard.vidsolbach.de/r/197/s/68/
> >
> >
> > Thanks,
> >
> > Marco