KDE/kdebase/workspace/plasma/applets/battery

[Sebastian Kügler]

On Thursday 18 September 2008 07:39:23 Aaron J. Seigo wrote:
> On Wednesday 17 September 2008, Sebastian Kügler wrote:
> > On Thursday 18 September 2008 04:34:37 Aaron J. Seigo wrote:
> > >   On Wednesday 17 September 2008, Sebastian Kügler wrote:
> > > > I'm still not getting the popup to pop up, out of ideas for now.
> > > > Maybe someone else can have a look, I'm kind of stuck.
> > >
> > > you haven't reimplemented widget() or graphicsWidget(); but don't
> > > worry, i'm making PopupApplet return extender() instead of 0 in the
> > > default implementation ... so if you just create an extender and don't
> > > reimplement graphicsWidget(), you get if for free now.
> >
> > Hm, I've done this, now removed it though, after your changes (thanks,
> > btw). That simplifies things a bit, but still the extender gets drawn on
> > top of my applet (see screenshot). There's no popup (though I've checked
> > with popupapplet, togglePopup() gets actually called.
>
> you need to call PopupApplet::constraintsEvent in your constraintsEvent ..
> maybe we should handle that differently .... like .... having a
> PopupAppletPrivate::constraintsEvent and have Applet check if it is a
> PopupApplet and if so call that constraintsEvent ...

Yes, sounds sensible. What I'd be expecting (in fact what I assumed) is that I 
don't need to call constraintsEvent, since in Applet that's also done 
automatically. Having PopupApplet behave the same would make the API more 
intuitive.

That said, the battery popup works now, thanks!
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080918/3ac00bef/attachment.sig