Review Request: some cosmetics to twitter applet

Marco Martin notmart at gmail.com
Tue Sep 16 20:46:34 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/193/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

this changes the look of the twitter applet using Plasma::frame instead of its custom and mostly identic graphics done before frame widget existed, so now the twitter widget is used just for the logo.
this also makes it behave better because now the graphics is managed by the layout instead of mixing layout items and paintinterface stuff that sometimes caused some weird results.
also adds a counter of the remaining characters and should display the error message (totally not sure if it's the right way)


Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/twitter/twitter.h
  /trunk/KDE/kdeplasma-addons/applets/twitter/twitter.cpp

Diff: http://reviewboard.vidsolbach.de/r/193/diff


Testing
-------


Screenshots
-----------

new look
  http://reviewboard.vidsolbach.de/r/193/s/63/


Thanks,

Marco



More information about the Plasma-devel mailing list