[PATCH] Fifteen puzzle sizing change (and other fixes)

[Anthony Bryant]

2008/9/15 Aaron J. Seigo <aseigo at kde.org>

> On Monday 15 September 2008, Anthony Bryant wrote:
> > I found another bug in the puzzle: double (or triple) clicking on a piece
>
> ok, the patch is now committed; i also went through and made the "split
> pixmap" version use an svg instead of a bitmap. now you can create an svg
> where each tile has the id of piece_# where # is 0..15 and it works. you
> can
> even put the image in the theme, though right now the configuration dialog
> doesn't particular honor that. this meant i could get rid of all the
> pixmaps
> hanging about.
>
>
Thanks for committing it =) There are a few things I noticed about your
changes though...
The most noticable one is that you can no longer use jpegs or other bitmaps
as the basis for the split image. I'm not sure what the original intentions
for this feature were, and I can see that allowing split svg could be
useful, but I would have thought that most people would expect to be able to
split up any image (e.g. photos), and not just specially crafted svgs.

Apart from this there's only one slight problem - the svg doesn't get set
back to the original one if you set it to use a custom image and then go
back to identical.

-Anthony
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20080915/08fc10aa/attachment.htm