Review Request: icon-less popupapplets and popupappletified clock

[Aaron J. Seigo]

On Friday 12 September 2008, Sebastian Kügler wrote:
> On Tuesday 09 September 2008 21:46:52 Marco Martin wrote:
> > the patch on popupapplet is derived from the aaron's one
> > and the clock uses it
> > thing that i noted: icon() badly clash with Applet::icon() (that's even
> > not virtual) it's really not the same thing, should have a different name
> > perhaps?
>
> I've applied the patch and ported the battery to make use of it.
> Unfortunately, it breaks the battery: its contensRect->size() becomes 0,0.
> I've attached the patch to the battery that causes this behaviour for me,
> maybe I'm doing something wrong ...

if you do this:

+    setIcon(QIcon());

then you need to set up your applet properly yourself. try moving the 
resize(128, 128) to after the setIcon call.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080912/5dfb6188/attachment-0001.sig