Review Request: Clock: remove "Use local time zone", add enabling/disabling code for "clockDefaultsTo"

Rafa? Mi?ecki zajec5 at gmail.com
Thu Sep 11 16:49:26 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/189/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This patch implements idea discussed on panel-devel at . This removes "Use local time zone" check box and make clockDefaultsTo disabled by default. clockDefaultsTo changes to enabled only if user selects something in KTimeZoneWidget. This is going to make using UI quite intuitive.

In code I used
if (d->ui.clockDefaultsTo->currentIndex() == 0) {
instead of just trusting that first position has "Local" string because this string should be translated in future.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp
  /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/timezonesConfig.ui

Diff: http://reviewboard.vidsolbach.de/r/189/diff


Testing
-------


Thanks,

Rafa?



More information about the Plasma-devel mailing list