Review Request: Merging PowerDevil engine with base/powermanagementengine
Dario Freddi
drf54321 at gmail.com
Thu Sep 11 16:37:13 CEST 2008
> On 2008-09-11 06:54:27, Sebastian Kügler wrote:
> > Other than my comments, it looks good to me, though I wouldn't mind someone else having another look at it ...
>
> Alessandro Diaferia wrote:
> the patch looks good to me too. just remove the whitespaces (highlighted in red here). =)
Fixed in my local copy :)
- Dario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/188/#review182
-----------------------------------------------------------
On 2008-09-11 07:08:52, Dario Freddi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/188/
> -----------------------------------------------------------
>
> (Updated 2008-09-11 07:08:52)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> As agreed on IRC with sebas, I'm porting PowerDevil engine to base powermanagement engine. This patch adds a keyword, "PowerDevil", and 2 sources, "currentProfile" and "availableProfiles", holding profiles data. I needed to add a small DBus architecture to make this work.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.h
> /trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.cpp
>
> Diff: http://reviewboard.vidsolbach.de/r/188/diff
>
>
> Testing
> -------
>
> Tested on my local copy, it works correctly with PowerDevil revision 859887+
>
>
> Thanks,
>
> Dario
>
>
More information about the Plasma-devel
mailing list