Review Request: Merging PowerDevil engine with base/powermanagementengine

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/188/#review182
-----------------------------------------------------------

Ship it!


Other than my comments, it looks good to me, though I wouldn't mind someone else having another look at it ...


/trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.cpp
<http://reviewboard.vidsolbach.de/r/188/#comment152>

    We can return here already, as the rest of the code assume that modules is not empty (and reply has to be valid for this) ... or make it 
    
    if (reply.isValid() && reply.value().contains("powerdevil")) {
    ...
    
    (untested, of course :P)
    



/trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.cpp
<http://reviewboard.vidsolbach.de/r/188/#comment153>

    Codingstyle, bla( "foo", ... => bla("foo", ...


- Sebastian


On 2008-09-11 06:36:48, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/188/
> -----------------------------------------------------------
> 
> (Updated 2008-09-11 06:36:48)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> As agreed on IRC with sebas, I'm porting PowerDevil engine to base powermanagement engine. This patch adds a keyword, "PowerDevil", and 2 sources, "currentProfile" and "availableProfiles", holding profiles data. I needed to add a small DBus architecture to make this work.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.h
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/188/diff
> 
> 
> Testing
> -------
> 
> Tested on my local copy, it works correctly with PowerDevil revision 859887+
> 
> 
> Thanks,
> 
> Dario
> 
>