Review Request: [MOCKUP] Clock: remove "Use local time zone"

Rafa? Mi?ecki zajec5 at gmail.com
Wed Sep 10 22:47:55 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/186/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Today we agreed with Aaron and Anne-Marie that we need some cleaning in time zone(s) selection (specially choices including local time zone).
My idea is to remove "Use local time zone", keep KTimeZoneWidget and QComboBox always enabled and put "Local" at top of QComboBox (no matter what is selected in KTimeZoneWidget). If user additionaly selects some other time zones in KTimeZoneWidget, then theses time zones are avaiable to choose in "Default clocks to" (QComboBox). Of course "Local" is then available as well.
What do you think about such a solution?


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp
  /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/timezonesConfig.ui

Diff: http://reviewboard.vidsolbach.de/r/186/diff


Testing
-------


Screenshots
-----------

New version of configuration dialog
  http://reviewboard.vidsolbach.de/r/186/s/60/


Thanks,

Rafa?



More information about the Plasma-devel mailing list